chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.cc - Issue 678653003: Remove Downcasting RVContextMenuBase in ContextMenuDeleagate implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.cc

Issue 678653003: Remove Downcasting RVContextMenuBase in ContextMenuDeleagate implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove virtual keyword when override is specified Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/app_browsertest.cc ('k') | chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.cc

diff --git a/chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.cc b/chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.cc

index c93001331dbc58c06b419d10e94d2c75dca533c6..f8000df8519a83d0767b5ffa58348326fa220625 100644

--- a/chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.cc

+++ b/chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.cc

@@ -21,7 +21,7 @@ bool ChromeAppViewGuestDelegate::HandleContextMenu(

ContextMenuDelegate::FromWebContents(web_contents);

DCHECK(menu_delegate);

- scoped_ptr<RenderViewContextMenu> menu =

+ scoped_ptr<RenderViewContextMenuBase> menu =

menu_delegate->BuildMenu(web_contents, params);

menu_delegate->ShowMenu(menu.Pass());

return true;