components/renderer_context_menu/render_view_context_menu_base.h - Issue 678653003: Remove Downcasting RVContextMenuBase in ContextMenuDeleagate implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/renderer_context_menu/render_view_context_menu_base.h

Issue 678653003: Remove Downcasting RVContextMenuBase in ContextMenuDeleagate implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sync @toot Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/renderer_context_menu/context_menu_delegate.h ('k') | components/renderer_context_menu/render_view_context_menu_base.cc » ('j') | content/public/common/context_menu_params.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/renderer_context_menu/render_view_context_menu_base.h

diff --git a/components/renderer_context_menu/render_view_context_menu_base.h b/components/renderer_context_menu/render_view_context_menu_base.h

index 45b3fc54b37044a0c9c6260dc88d6f3ebcff40e5..3f3069789cfed8e2da82918d0e28f7f093fd676b 100644

--- a/components/renderer_context_menu/render_view_context_menu_base.h

+++ b/components/renderer_context_menu/render_view_context_menu_base.h

@@ -69,6 +69,10 @@ class RenderViewContextMenuBase : public ui::SimpleMenuModel::Delegate,

~RenderViewContextMenuBase() override;

+ // Displays the menu.

+ // Different platform will have their own implementation.

+ virtual void Show() = 0;

// Initializes the context menu.

void Init();

@@ -121,6 +125,8 @@ class RenderViewContextMenuBase : public ui::SimpleMenuModel::Delegate,

}

// TODO(oshima): Make these methods delegate.

+ // Fills in |params_| with screen coordinates.

+ virtual void CalculateScreenCoordinatesInParams() = 0;

// Menu Construction.

virtual void InitMenu();