Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1559)

Unified Diff: chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.h

Issue 678653003: Remove Downcasting RVContextMenuBase in ContextMenuDeleagate implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync @toot Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.h
diff --git a/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.h b/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.h
index 3c8a906eeb7eec14a68b44b7b6e13670d72a53d5..a8cf957bd98936559ff279c74fdbc2d297ae9d98 100644
--- a/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.h
+++ b/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.h
@@ -8,6 +8,10 @@
#include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
#include "ui/base/ui_base_types.h"
+namespace aura {
+class Window;
+}
+
namespace gfx {
class Point;
}
@@ -31,11 +35,15 @@ class RenderViewContextMenuViews : public RenderViewContextMenu {
virtual void ExecuteCommand(int command_id, int event_flags) override;
+ // RenderViewContextMenuBase implementation.
+ virtual void Show() override;
+
protected:
RenderViewContextMenuViews(content::RenderFrameHost* render_frame_host,
const content::ContextMenuParams& params);
- // RenderViewContextMenu implementation.
+ // RenderViewContextMenuBase implementation.
+ virtual void CalculateScreenCoordinatesInParams() override;
virtual bool GetAcceleratorForCommandId(
int command_id,
ui::Accelerator* accelerator) override;
@@ -45,6 +53,9 @@ class RenderViewContextMenuViews : public RenderViewContextMenu {
virtual bool IsCommandIdChecked(int command_id) const override;
virtual bool IsCommandIdEnabled(int command_id) const override;
+ aura::Window* GetActiveNativeView();
+ views::Widget* GetTopLevelWidget();
+
// Model for the BiDi input submenu.
ui::SimpleMenuModel bidi_submenu_model_;
DISALLOW_COPY_AND_ASSIGN(RenderViewContextMenuViews);

Powered by Google App Engine
This is Rietveld 408576698