chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.h - Issue 678653003: Remove Downcasting RVContextMenuBase in ContextMenuDeleagate implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.h

Issue 678653003: Remove Downcasting RVContextMenuBase in ContextMenuDeleagate implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sync @toot Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h ('k') | chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm » ('j') | content/public/common/context_menu_params.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.h

diff --git a/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.h b/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.h

index c383e9c88f74acb947a6c139c27faf416bf3f3bb..f4f1fecd8d38305634d6b556bbea469d1555a878 100644

--- a/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.h

+++ b/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.h

@@ -27,10 +27,12 @@ class RenderViewContextMenuMac : public RenderViewContextMenu {

bool IsCommandIdChecked(int command_id) const override;

bool IsCommandIdEnabled(int command_id) const override;

- void Show();

+ // RenderViewContextMenuBase implementation.

+ void Show() override;

protected:

- // RenderViewContextMenu implementation.

+ // RenderViewContextMenuBase implementation.

+ void CalculateScreenCoordinatesInParams() override;

bool GetAcceleratorForCommandId(int command_id,

ui::Accelerator* accelerator) override;

void AppendPlatformEditableItems() override;