chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.cc - Issue 678653003: Remove Downcasting RVContextMenuBase in ContextMenuDeleagate implementations.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.cc

Issue 678653003: Remove Downcasting RVContextMenuBase in ContextMenuDeleagate implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove virtual keyword when override is specified Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.cc ('k') | chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/guest_view/extension_options/chrome_extension_options_g uest_delegate.h"	5 #include "chrome/browser/guest_view/extension_options/chrome_extension_options_g uest_delegate.h"

6	6

7 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"	7 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"

8 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h"	8 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h"

9 #include "chrome/browser/ui/browser.h"	9 #include "chrome/browser/ui/browser.h"

10 #include "chrome/browser/ui/browser_finder.h"	10 #include "chrome/browser/ui/browser_finder.h"

(...skipping 14 matching lines...) Expand all Loading...
25 ChromeExtensionWebContentsObserver::CreateForWebContents(	25 ChromeExtensionWebContentsObserver::CreateForWebContents(

26 extension_options_guest()->web_contents());	26 extension_options_guest()->web_contents());

27 }	27 }

28	28

29 bool ChromeExtensionOptionsGuestDelegate::HandleContextMenu(	29 bool ChromeExtensionOptionsGuestDelegate::HandleContextMenu(

30 const content::ContextMenuParams& params) {	30 const content::ContextMenuParams& params) {

31 ContextMenuDelegate* menu_delegate = ContextMenuDelegate::FromWebContents(	31 ContextMenuDelegate* menu_delegate = ContextMenuDelegate::FromWebContents(

32 extension_options_guest()->web_contents());	32 extension_options_guest()->web_contents());

33 DCHECK(menu_delegate);	33 DCHECK(menu_delegate);

34	34

35 scoped_ptr<RenderViewContextMenu> menu = menu_delegate->BuildMenu(	35 scoped_ptr<RenderViewContextMenuBase> menu = menu_delegate->BuildMenu(

36 extension_options_guest()->web_contents(), params);	36 extension_options_guest()->web_contents(), params);

37 menu_delegate->ShowMenu(menu.Pass());	37 menu_delegate->ShowMenu(menu.Pass());

38 return true;	38 return true;

39 }	39 }

40	40

41 content::WebContents* ChromeExtensionOptionsGuestDelegate::OpenURLInNewTab(	41 content::WebContents* ChromeExtensionOptionsGuestDelegate::OpenURLInNewTab(

42 const content::OpenURLParams& params) {	42 const content::OpenURLParams& params) {

43 Browser* browser = chrome::FindBrowserWithWebContents(	43 Browser* browser = chrome::FindBrowserWithWebContents(

44 extension_options_guest()->embedder_web_contents());	44 extension_options_guest()->embedder_web_contents());

45 return browser->OpenURL(params);	45 return browser->OpenURL(params);

46 }	46 }

47	47

48 } // namespace extensions	48 } // namespace extensions

OLD	NEW