Remove Downcasting RVContextMenuBase in ContextMenuDeleagate implementations.

content/public/common/context_menu_params.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_COMMON_CONTEXT_MENU_PARAMS_H_
 #define CONTENT_PUBLIC_COMMON_CONTEXT_MENU_PARAMS_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 43 matching lines @@
   ~ContextMenuParams();
 
   // This is the type of Context Node that the context menu was invoked on.
   blink::WebContextMenuData::MediaType media_type;
 
   // These values represent the coordinates of the mouse when the context menu
   // was invoked.  Coords are relative to the associated RenderView's origin.
   int x;
   int y;
 
+  // These values represent the screen coordicates of the mouse when the
+  // context menu was invoked.  These values are set in the browser/.
+  float screen_x;

[sky, 2014/10/27 19:24:53]

These should be set in content before the params are passed to the delegate.

[lazyboy, 2014/10/27 22:01:13]

I just hit a bump while doing this in RenderFrameHostImpl::OnContextMenu()

aura uses screen coordinates to bring up the context menu,
but mac actually doesn't, it rather requires coordinates within window
with y flipped so that 0 is at the bottom edge :(

In this case, calling this screen_x/y makes things confusing.
How about view_x/y?

My current plan is:
Add
virtual gfx::PointF
RenderWidgetHostViewBase::ConvertPointToContextMenuCoordinates() = 0;

and change:
RenderFrameHostImpl::OnContextMenu(ContextMenuParams params) {
  ..
  gfx::PointF view_point =
      render_view_host_->GetView()->ConvertPointToContextMenuCoordinates(
          gfx::Point(params.x, params.y));
  params.view_x = view_point.x();
  params.view_y = view_point.y();

  delegate_->ShowContextMenu(this, params);  
}

WDYT?

+  float screen_y;
+
   // This is the URL of the link that encloses the node the context menu was
   // invoked on.
   GURL link_url;
 
   // The text associated with the link. May be an empty string if the contents
   // of the link are an image.
   // Will be empty if link_url is empty.
   base::string16 link_text;
 
   // The link URL to be used ONLY for "copy link address". We don't validate
@@ skipping 81 matching lines @@
   // Points representing the coordinates in the document space of the start and
   // end of the selection, if there is one.
   gfx::Point selection_start;
   gfx::Point selection_end;
 #endif
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_CONTEXT_MENU_PARAMS_H_