add pagination info to DistilledPageProto

components/dom_distiller/core/distiller.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/dom_distiller/core/distiller.h"
 
 #include <map>
 #include <vector>
 
 #include "base/auto_reset.h"
@@ skipping 152 matching lines @@
 
     if (distiller_result->has_pagination_info()) {
       proto::PaginationInfo pagination_info =
           distiller_result->pagination_info();
       if (pagination_info.has_next_page()) {
         GURL next_page_url(pagination_info.next_page());
         if (next_page_url.is_valid()) {
           // The pages should be in same origin.
           DCHECK_EQ(next_page_url.GetOrigin(), page_url.GetOrigin());
           AddToDistillationQueue(page_num + 1, next_page_url);
+          page_data->distilled_page_proto->data.mutable_pagination_info()->
+              set_next_page(next_page_url.spec());
         }
       }
 
       if (pagination_info.has_prev_page()) {
         GURL prev_page_url(pagination_info.prev_page());
         if (prev_page_url.is_valid()) {
           DCHECK_EQ(prev_page_url.GetOrigin(), page_url.GetOrigin());
           AddToDistillationQueue(page_num - 1, prev_page_url);
+          page_data->distilled_page_proto->data.mutable_pagination_info()->

[nyquist, 2014/10/24 20:04:02]

Since you added canonical_page to the DistilledPage::PaginationInfo proto, any
specific reason you do not copy the value over from the distiller result here?

[kuan, 2014/10/24 20:57:32]

Done.  no reason, except that it's not used, but i guess the same argument cld
be made for prev_page.

+              set_prev_page(prev_page_url.spec());
         }
       }
     }
 
     for (int img_num = 0; img_num < distiller_result->image_urls_size();
          ++img_num) {
       std::string image_id =
           base::IntToString(page_num + 1) + "_" + base::IntToString(img_num);
       FetchImage(page_num, image_id, distiller_result->image_urls(img_num));
     }
@@ skipping 114 matching lines @@
     DCHECK(finished_pages_index_.empty());
 
     base::AutoReset<bool> dont_delete_this_in_callback(&destruction_allowed_,
                                                        false);
     finished_cb_.Run(article_proto.Pass());
     finished_cb_.Reset();
   }
 }
 
 }  // namespace dom_distiller