Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: src/IceTypes.def

Issue 678533005: Subzero: Add basic ELFObjectWriter (text section, symtab, strtab, headers) (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: stuff Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceTypes.def
diff --git a/src/IceTypes.def b/src/IceTypes.def
index 3d4c9b179ee19d0861fccfd2648c1498ea187181..2833dd82bf98cb48ef2a132a77675a185f37649e 100644
--- a/src/IceTypes.def
+++ b/src/IceTypes.def
@@ -15,13 +15,18 @@
#ifndef SUBZERO_SRC_ICETYPES_DEF
#define SUBZERO_SRC_ICETYPES_DEF
-#define TARGETARCH_TABLE \
- /* enum value, printable string */ \
- X(Target_X8632, "x86-32") \
- X(Target_X8664, "x86-64") \
- X(Target_ARM32, "arm32") \
- X(Target_ARM64, "arm64") \
-//#define X(tag, str)
+// Attributes of each target architecture.
+// NOTE on is_elf64 -- At some point NaCl would like to use ELF32 for all
+// ILP32 sandboxes, but for now the 64-bit architectures use ELF64:
+// https://code.google.com/p/nativeclient/issues/detail?id=349
+// TODO: Whoever adds AArch64 will need to set ABI e_flags.
+#define TARGETARCH_TABLE \
+ /* enum value, printable string, is_elf64, e_machine, e_flags */ \
+ X(Target_X8632, "x86-32", false, EM_386, 0) \
+ X(Target_X8664, "x86-64", true, EM_X86_64, 0) \
+ X(Target_ARM32, "arm32", false, EM_ARM, EF_ARM_EABI_VER5) \
+ X(Target_ARM64, "arm64", true, EM_AARCH64, 0) \
+ //#define X(tag, str)
Jim Stichnoth 2014/11/21 21:32:22 update comment with new args
jvoung (off chromium) 2014/11/24 21:35:46 Done.
#define ICETYPE_TABLE \
/* enum value, size, align, # elts, element type, printable string */ \

Powered by Google App Engine
This is Rietveld 408576698