src/IceTargetLoweringX8632.cpp - Issue 678533005: Subzero: Add basic ELFObjectWriter (text section, symtab, strtab, headers)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX8632.cpp

Issue 678533005: Subzero: Add basic ELFObjectWriter (text section, symtab, strtab, headers) (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: cleanup Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLoweringX8632.cpp

diff --git a/src/IceTargetLoweringX8632.cpp b/src/IceTargetLoweringX8632.cpp

index 82d20b422e22c7829a6f248469f88a0fd00c53bd..afad98fae42aa10760e8909277f5450f5d46f104 100644

--- a/src/IceTargetLoweringX8632.cpp

+++ b/src/IceTargetLoweringX8632.cpp

@@ -4564,6 +4564,9 @@ TargetGlobalInitX8632::TargetGlobalInitX8632(GlobalContext *Ctx)

: TargetGlobalInitLowering(Ctx) {}

void TargetGlobalInitX8632::lower(const VariableDeclaration &Var) {

+ // TODO(jvoung): handle this without text.

+ if (Ctx->getFlags().UseELFWriter)

+ return;

Ostream &Str = Ctx->getStrEmit();

« src/IceMemoryRegion.h ('K') | « src/IceTargetLoweringX8632.h ('k') | src/IceTranslator.h » ('j') | no next file with comments »