Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 678533003: Remove HTMLTreeBuilderSimulator (Closed)

Created:
6 years, 2 months ago by abarth-chromium
Modified:
6 years, 2 months ago
Reviewers:
eseidel
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Visibility:
Public.

Description

Remove HTMLTreeBuilderSimulator There's no need to simulate the tree builder. It doesn't have any state. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/05c3c9f0d6479ebd11695ce48e3ae96ef48bead8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -121 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/html/parser/BackgroundHTMLParser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/html/parser/BackgroundHTMLParser.cpp View 4 chunks +24 lines, -2 lines 0 comments Download
M sky/engine/core/html/parser/HTMLDocumentParser.h View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/core/html/parser/HTMLTreeBuilderSimulator.h View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/engine/core/html/parser/HTMLTreeBuilderSimulator.cpp View 1 chunk +0 lines, -63 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
abarth-chromium
6 years, 2 months ago (2014-10-23 22:43:43 UTC) #1
eseidel
lgtm
6 years, 2 months ago (2014-10-23 22:44:29 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 2 months ago (2014-10-23 22:46:42 UTC) #5
abarth-chromium
6 years, 2 months ago (2014-10-23 22:47:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
05c3c9f0d6479ebd11695ce48e3ae96ef48bead8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698