Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 678533002: Fix sky build on android (Closed)

Created:
6 years, 2 months ago by jamesr
Modified:
6 years, 2 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -19 lines) Patch
M sky/BUILD.gn View 2 chunks +10 lines, -3 lines 0 comments Download
M sky/engine/platform/BUILD.gn View 3 chunks +23 lines, -12 lines 0 comments Download
M sky/engine/public/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jamesr
6 years, 2 months ago (2014-10-23 21:44:30 UTC) #2
abarth-chromium
lgtm
6 years, 2 months ago (2014-10-23 21:45:58 UTC) #3
jamesr
6 years, 2 months ago (2014-10-23 21:50:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
90fdf899a628dd10ebec35a8a4803a161872dee5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698