Issue 678513002: Service Worker: Remove invalid test case for Cache.put() rejection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 678513002: Service Worker: Remove invalid test case for Cache.put() rejection (Closed)

Created:
6 years, 2 months ago by jsbell

Modified:
6 years, 2 months ago

Reviewers:
asanka

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, jkarlin

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Service Worker: Remove invalid test case for Cache.put() rejection The test case was asserting that 'get' was not a valid method for Cache.put(). But per the fetch spec, the Request's method is normalized during construction so 'get' becomes 'GET' and that's valid. There's a later test case which covers this using 'HEAD', so just remove it. BUG=374802 R=asanka@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184372

Patch Set 1 #

Patch Set 2 : Rebased #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -9 lines)			Patch
	M	LayoutTests/http/tests/serviceworker/cache-put-expected.txt	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jsbell

asanka@ - please take a look? Another one I should have caught, sorry. :( Per ...

6 years, 2 months ago (2014-10-23 21:11:20 UTC) #1

jsbell

6 years, 2 months ago (2014-10-24 16:47:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 184372 (presubmit successful).

Expand Messages | Collapse Messages