Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 678483005: Add a test for font/line-height cascade. (Closed)

Created:
6 years, 2 months ago by andersr
Modified:
6 years, 2 months ago
Reviewers:
Timothy Loh, rune
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add a test for font/line-height cascade. The line-height property has lots of special handling in the style resolver which we want to remove at some point. When we do, it's nice to know that this still works correctly. R=rune@opera.com BUG=353932 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184346

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
A LayoutTests/fast/css/font-shorthand-line-height.html View 1 chunk +32 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/font-shorthand-line-height-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
andersr
6 years, 2 months ago (2014-10-24 09:17:48 UTC) #1
andersr
Note: I verified that this fails with https://codereview.chromium.org/670373002/ .
6 years, 2 months ago (2014-10-24 09:20:01 UTC) #2
rune
lgtm Out of curiosity, do these tests all pass in Gecko and Trident?
6 years, 2 months ago (2014-10-24 09:25:05 UTC) #3
Timothy Loh
On 2014/10/24 09:17:48, andersr wrote: lgtm
6 years, 2 months ago (2014-10-24 09:34:07 UTC) #4
andersr
> Out of curiosity, do these tests all pass in Gecko and Trident? Trident: Yes. ...
6 years, 2 months ago (2014-10-24 09:47:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678483005/1
6 years, 2 months ago (2014-10-24 09:47:56 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 10:49:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184346

Powered by Google App Engine
This is Rietveld 408576698