Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 678483003: Adds web::NavigationItemImpl. (Closed)

Created:
6 years, 2 months ago by rohitrao (ping after 24h)
Modified:
6 years, 2 months ago
Reviewers:
*stuartmorgan, blundell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adds web::NavigationItemImpl. This is the concrete implementation of the web::NavigationItem interface. BUG=422033 TEST=None Committed: https://crrev.com/995246d92aea4f343797fa869d3aef4d94fd5450 Cr-Commit-Position: refs/heads/master@{#301109}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -0 lines) Patch
M ios/ios_tests_unit.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/web/ios_web.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
A ios/web/navigation/navigation_item_impl.h View 1 chunk +70 lines, -0 lines 0 comments Download
A ios/web/navigation/navigation_item_impl.mm View 1 chunk +151 lines, -0 lines 0 comments Download
A ios/web/navigation/navigation_item_impl_unittest.mm View 1 1 chunk +33 lines, -0 lines 0 comments Download
M ios/web/public/navigation_item.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
rohitrao (ping after 24h)
Oh man the test passes and everything. https://codereview.chromium.org/678483003/diff/1/ios/web/navigation/navigation_item_impl.h File ios/web/navigation/navigation_item_impl.h (right): https://codereview.chromium.org/678483003/diff/1/ios/web/navigation/navigation_item_impl.h#newcode27 ios/web/navigation/navigation_item_impl.h:27: virtual int ...
6 years, 2 months ago (2014-10-23 20:29:37 UTC) #3
blundell
lgtm https://codereview.chromium.org/678483003/diff/1/ios/web/navigation/navigation_item_impl_unittest.mm File ios/web/navigation/navigation_item_impl_unittest.mm (right): https://codereview.chromium.org/678483003/diff/1/ios/web/navigation/navigation_item_impl_unittest.mm#newcode25 ios/web/navigation/navigation_item_impl_unittest.mm:25: // TODO(stuartmorgan): Remove this once NavigationItem has actual ...
6 years, 2 months ago (2014-10-24 07:26:50 UTC) #4
stuartmorgan
lgtm https://codereview.chromium.org/678483003/diff/1/ios/web/navigation/navigation_item_impl_unittest.mm File ios/web/navigation/navigation_item_impl_unittest.mm (right): https://codereview.chromium.org/678483003/diff/1/ios/web/navigation/navigation_item_impl_unittest.mm#newcode25 ios/web/navigation/navigation_item_impl_unittest.mm:25: // TODO(stuartmorgan): Remove this once NavigationItem has actual ...
6 years, 2 months ago (2014-10-24 14:57:48 UTC) #5
rohitrao (ping after 24h)
https://codereview.chromium.org/678483003/diff/1/ios/web/navigation/navigation_item_impl_unittest.mm File ios/web/navigation/navigation_item_impl_unittest.mm (right): https://codereview.chromium.org/678483003/diff/1/ios/web/navigation/navigation_item_impl_unittest.mm#newcode25 ios/web/navigation/navigation_item_impl_unittest.mm:25: // TODO(stuartmorgan): Remove this once NavigationItem has actual On ...
6 years, 2 months ago (2014-10-24 15:08:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678483003/20001
6 years, 2 months ago (2014-10-24 15:09:58 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-24 15:55:47 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 15:56:29 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/995246d92aea4f343797fa869d3aef4d94fd5450
Cr-Commit-Position: refs/heads/master@{#301109}

Powered by Google App Engine
This is Rietveld 408576698