Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 678453004: IDL: Use implicit false in compute_info_individual() (Closed)

Created:
6 years, 2 months ago by bashi
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: Use implicit false in compute_info_individual() This is a minor style correction. We'd prefer the 'implicit false' rather than 'len(array) > 0'. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184324

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/bindings/scripts/compute_interfaces_info_individual.py View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
bashi
PTAL? This is a follow-up CL of https://codereview.chromium.org/670663002/
6 years, 2 months ago (2014-10-23 22:54:17 UTC) #2
Nils Barth (inactive)
LGTM, thanks!
6 years, 2 months ago (2014-10-23 22:57:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678453004/1
6 years, 2 months ago (2014-10-23 23:04:22 UTC) #5
haraken
LGTM
6 years, 2 months ago (2014-10-23 23:30:27 UTC) #6
commit-bot: I haz the power
Failed to apply patch for Source/bindings/scripts/compute_interfaces_info_individual.py: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 2 months ago (2014-10-24 00:54:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678453004/20001
6 years, 2 months ago (2014-10-24 00:59:41 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 02:39:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184324

Powered by Google App Engine
This is Rietveld 408576698