Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 678423003: mac: Opening a URL should replace the NTP. (Closed)

Created:
6 years, 1 month ago by erikchen
Modified:
6 years, 1 month ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mac: Opening a URL should replace the NTP. When a browser window is instructed to open a URL, if the only existing tab is the NTP, the NTP should be replaced with a tab with the given URL. This was partially fixed by https://codereview.chromium.org/240273002, but that only tackled the case where Chrome was launched as a result of an open URL Apple Event. This CL replicates the behavior for Chrome receiving a URL from Handoff, and for Chrome receiving an open URL Apple Event while Chrome is already running. BUG=428081, 43520 Committed: https://crrev.com/19ee3922f7438d37833ae5ec58af10518b4a6c47 Cr-Commit-Position: refs/heads/master@{#302304}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Comments from avi. #

Patch Set 3 : Start embedded test server in browser test. #

Patch Set 4 : Fix the tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -33 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 9 chunks +32 lines, -11 lines 0 comments Download
M chrome/browser/app_controller_mac_browsertest.mm View 1 2 3 4 chunks +74 lines, -22 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
erikchen
avi: Please review.
6 years, 1 month ago (2014-10-28 22:38:35 UTC) #3
Avi (use Gerrit)
lgtm https://codereview.chromium.org/678423003/diff/20001/chrome/browser/app_controller_mac.mm File chrome/browser/app_controller_mac.mm (right): https://codereview.chromium.org/678423003/diff/20001/chrome/browser/app_controller_mac.mm#newcode235 chrome/browser/app_controller_mac.mm:235: // Opens a tab for each GURL in ...
6 years, 1 month ago (2014-10-29 14:38:59 UTC) #4
erikchen
https://codereview.chromium.org/678423003/diff/20001/chrome/browser/app_controller_mac.mm File chrome/browser/app_controller_mac.mm (right): https://codereview.chromium.org/678423003/diff/20001/chrome/browser/app_controller_mac.mm#newcode235 chrome/browser/app_controller_mac.mm:235: // Opens a tab for each GURL in |urls|. ...
6 years, 1 month ago (2014-10-29 17:18:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678423003/40001
6 years, 1 month ago (2014-10-29 17:19:56 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/builds/7611)
6 years, 1 month ago (2014-10-29 18:14:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678423003/40001
6 years, 1 month ago (2014-10-29 18:21:00 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/builds/7637)
6 years, 1 month ago (2014-10-29 19:36:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678423003/60001
6 years, 1 month ago (2014-10-29 19:56:02 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/builds/7721)
6 years, 1 month ago (2014-10-29 22:02:56 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678423003/80001
6 years, 1 month ago (2014-10-31 18:29:47 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:80001)
6 years, 1 month ago (2014-10-31 19:14:29 UTC) #20
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 19:15:05 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/19ee3922f7438d37833ae5ec58af10518b4a6c47
Cr-Commit-Position: refs/heads/master@{#302304}

Powered by Google App Engine
This is Rietveld 408576698