Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: pkg/analysis_server/test/integration/integration_tests.dart

Issue 678413003: Avoid analysis server crash when reanalyze invoked during analysis. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Change bool to only be true when performOperation pending. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/integration/analysis/test_all.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/integration/integration_tests.dart
diff --git a/pkg/analysis_server/test/integration/integration_tests.dart b/pkg/analysis_server/test/integration/integration_tests.dart
index a2e188ddf45e936d4c0b2c73d68bd755a35587af..4436253022f8643f65e5a555def93044f7bd84fd 100644
--- a/pkg/analysis_server/test/integration/integration_tests.dart
+++ b/pkg/analysis_server/test/integration/integration_tests.dart
@@ -154,6 +154,10 @@ abstract class AbstractAnalysisServerIntegrationTest extends
expect(serverConnected.isCompleted, isFalse);
serverConnected.complete();
});
+ onServerError.listen((ServerErrorParams params) {
+ // A server error should never happen during an integration test.
+ fail(params.message);
+ });
return server.start().then((_) {
server.listenToOutput(dispatchNotification);
server.exitCode.then((_) {
« no previous file with comments | « pkg/analysis_server/test/integration/analysis/test_all.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698