pkg/analysis_server/test/analysis_server_test.dart - Issue 678413003: Avoid analysis server crash when reanalyze invoked during analysis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/analysis_server_test.dart

Issue 678413003: Avoid analysis server crash when reanalyze invoked during analysis. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Change bool to only be true when performOperation pending. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/analysis_server.dart ('k') | pkg/analysis_server/test/integration/analysis/reanalyze_concurrent_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/analysis_server_test.dart

diff --git a/pkg/analysis_server/test/analysis_server_test.dart b/pkg/analysis_server/test/analysis_server_test.dart

index b138eb661693fe13b1ab81b4a2fd329e8b0ee178..d26041ae580d5bfaaa5447965ad15a1bd62df96c 100644

--- a/pkg/analysis_server/test/analysis_server_test.dart

+++ b/pkg/analysis_server/test/analysis_server_test.dart

@@ -94,6 +94,7 @@ main() {

MockServerOperation operation = new MockServerOperation(

ServerOperationPriority.ANALYSIS, (_) { throw exceptionToThrow; });

helper.server.operationQueue.add(operation);

+ helper.server.performOperationPending = true;

try {

helper.server.performOperation();

fail('exception not rethrown');