Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 678413002: net: move the FALLBACK_SCSV to the back of the cipher suite list. (Closed)

Created:
6 years, 1 month ago by agl
Modified:
6 years, 1 month ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

net: move the FALLBACK_SCSV to the back of the cipher suite list. Yngve Pettersen reports better compatibility with this value at the end of the list and OpenSSL had a bug around process it when it was first. (I pondered moving the reneg SCSV to the end also but that code is from upstream and reneg SCSV is only sent for SSLv3, which is not a going concern any longer.) BUG=none Committed: https://crrev.com/0aad74ad1d2e14e38e5b7671de78bae3f40e992b Cr-Commit-Position: refs/heads/master@{#301941}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -16 lines) Patch
M net/third_party/nss/patches/fallbackscsv.patch View 2 chunks +13 lines, -7 lines 0 comments Download
M net/third_party/nss/ssl/ssl3con.c View 2 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
agl
6 years, 1 month ago (2014-10-28 19:27:11 UTC) #2
Ryan Sleevi
lgtm
6 years, 1 month ago (2014-10-29 20:35:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678413002/1
6 years, 1 month ago (2014-10-29 20:37:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-29 21:44:56 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 21:45:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0aad74ad1d2e14e38e5b7671de78bae3f40e992b
Cr-Commit-Position: refs/heads/master@{#301941}

Powered by Google App Engine
This is Rietveld 408576698