Discard atlas after every MultiPictureDraw::draw

Discard atlas after every MultiPictureDraw::draw

This is intended to prevent ghosting on tiled architectures.

This CL also defers creation of the atlas (and its texture) until it is actually needed.

Committed: https://skia.googlesource.com/skia/+/6d5b5455743414ddb11d2b8c1fe9d7959f2b853d

Committed: https://skia.googlesource.com/skia/+/4ab5a9048cf327adfc9ef9757ea956d7003ba047

[robertphillips, 2014-10-28 21:00:45]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[bsalomon, 2014-10-29 13:53:41]

lgtm

[robertphillips, 2014-10-29 14:55:35]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-10-29 14:56:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/678403002/60001

[commit-bot: I haz the power, 2014-10-29 15:05:26]

Committed patchset #4 (id:60001) as 6d5b5455743414ddb11d2b8c1fe9d7959f2b853d

[robertphillips, 2014-10-29 15:16:47]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/687233002/ by robertphillips@google.com.

The reason for reverting is: Breaking bots.

[robertphillips, 2014-10-29 16:52:23]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-10-29 16:53:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/678403002/80001

[commit-bot: I haz the power, 2014-10-29 19:46:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-29 19:46:46]

Failed to apply patch for src/core/SkMultiPictureDraw.cpp:
While running git apply --index -3 -p1;
  error: patch failed: src/core/SkMultiPictureDraw.cpp:146
  Falling back to three-way merge...
  Applied patch to 'src/core/SkMultiPictureDraw.cpp' with conflicts.
  U src/core/SkMultiPictureDraw.cpp

Patch:       src/core/SkMultiPictureDraw.cpp
Index: src/core/SkMultiPictureDraw.cpp
diff --git a/src/core/SkMultiPictureDraw.cpp b/src/core/SkMultiPictureDraw.cpp
index
5fe3c0ea5210aa0a5969e7afb97143991bd7a37d..7d6639b4df4eec54fe1e633e56c71541e1f36101
100644
--- a/src/core/SkMultiPictureDraw.cpp
+++ b/src/core/SkMultiPictureDraw.cpp
@@ -146,6 +146,9 @@ void SkMultiPictureDraw::draw() {
     if (NULL != context) {
         GrLayerHoister::UnlockLayers(context, atlasedNeedRendering);
         GrLayerHoister::UnlockLayers(context, atlasedRecycled);
+#if !GR_CACHE_HOISTED_LAYERS
+        GrLayerHoister::PurgeCache(context);
+#endif
     }
 #endif

[commit-bot: I haz the power, 2014-10-29 19:46:47]

The CQ bit was unchecked by commit-bot@chromium.org

[robertphillips, 2014-10-29 20:46:12]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-10-29 20:46:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/678403002/100001

[commit-bot: I haz the power, 2014-10-29 20:56:07]

Committed patchset #6 (id:100001) as 4ab5a9048cf327adfc9ef9757ea956d7003ba047