extensions/renderer/resources/uncaught_exception_handler.js - Issue 678393002: Send extension console messages to the right WebFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/uncaught_exception_handler.js

Issue 678393002: Send extension console messages to the right WebFrame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/resources/uncaught_exception_handler.js

diff --git a/extensions/renderer/resources/uncaught_exception_handler.js b/extensions/renderer/resources/uncaught_exception_handler.js

index f87efbc995c50ad7a8ceafcbdbcf081c2a193a93..2c36440d2330abd8f8690ca79bd7563bd3d74ac1 100644

--- a/extensions/renderer/resources/uncaught_exception_handler.js

+++ b/extensions/renderer/resources/uncaught_exception_handler.js

@@ -5,7 +5,7 @@

// Handles uncaught exceptions thrown by extensions. By default this is to

// log an error message, but tests may override this behaviour.

var handler = function(message, e) {

- console.error(message);

+ window.console.error(message);

not at google - send to devlin 2014/10/28 16:00:41 The use of console rather than window.console here

};

/**

« no previous file with comments | « no previous file | no next file » | no next file with comments »