Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 678373004: [Android] Adding MIPS64 target to gyp_webview (Closed)

Created:
6 years, 1 month ago by gordanac
Modified:
6 years, 1 month ago
Reviewers:
Torne, gordanac
CC:
chromium-reviews, android-webview-reviews_chromium.org, petar.jovanovic, Paul Lind
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Adding MIPS64 target to gyp_webview This change enables creation of webview Android make files for MIPS64. BUG=400684 Committed: https://crrev.com/2d0da5605d758f8868d623da6cddbdd06f3e7015 Cr-Commit-Position: refs/heads/master@{#302783}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M android_webview/tools/gyp_webview View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
gordanac
Please take a look.
6 years, 1 month ago (2014-10-29 17:02:48 UTC) #2
Torne
Does the MIPS64 build actually compile successfully? If this lands, then MIPS64 builds of android ...
6 years, 1 month ago (2014-10-29 17:08:57 UTC) #3
gordanac
On 2014/10/29 17:08:57, Torne wrote: > Does the MIPS64 build actually compile successfully? If this ...
6 years, 1 month ago (2014-10-31 10:41:42 UTC) #4
Torne
On 2014/10/31 10:41:42, gordanac wrote: > On 2014/10/29 17:08:57, Torne wrote: > > Does the ...
6 years, 1 month ago (2014-10-31 10:43:12 UTC) #5
gordanac
On 2014/10/31 10:43:12, Torne wrote: > On 2014/10/31 10:41:42, gordanac wrote: > > On 2014/10/29 ...
6 years, 1 month ago (2014-10-31 11:07:24 UTC) #6
gordanac
On 2014/10/31 11:07:24, gordanac wrote: > On 2014/10/31 10:43:12, Torne wrote: > > On 2014/10/31 ...
6 years, 1 month ago (2014-11-05 11:00:56 UTC) #7
Torne
lgtm
6 years, 1 month ago (2014-11-05 11:06:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678373004/1
6 years, 1 month ago (2014-11-05 11:15:59 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-05 12:06:13 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 12:06:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d0da5605d758f8868d623da6cddbdd06f3e7015
Cr-Commit-Position: refs/heads/master@{#302783}

Powered by Google App Engine
This is Rietveld 408576698