chrome/browser/browser_commands_unittest.cc - Issue 678343002: Default zoom was never read from chrome://settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_commands_unittest.cc

Issue 678343002: Default zoom was never read from chrome://settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Renamed function names to something intuitive Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/browser_commands_unittest.cc

diff --git a/chrome/browser/browser_commands_unittest.cc b/chrome/browser/browser_commands_unittest.cc

index d9ca97424de7f736d6dc3386c7d1c96e3b028404..e8b0d92b5ea21600c841933943540afbc35c9e1e 100644

--- a/chrome/browser/browser_commands_unittest.cc

+++ b/chrome/browser/browser_commands_unittest.cc

@@ -285,7 +285,7 @@ TEST_F(BrowserCommandsTest, OnZoomReset) {

chrome_page_zoom::Zoom(contents1, content::PAGE_ZOOM_RESET);

ZoomController* zoom_controller = ZoomController::FromWebContents(contents1);

- EXPECT_EQ(zoom_controller->GetZoomPercent(), 100.0f);

+ EXPECT_EQ(zoom_controller->GetZoomPercent(), 100.f);

Alexei Svitkine (slow) 2014/10/30 13:49:42 Nit: Your only change to this file now is 100.0f -

EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_ZOOM_PLUS));

EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_ZOOM_NORMAL));

EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_ZOOM_MINUS));