content/renderer/render_view_impl.cc - Issue 678343002: Default zoom was never read from chrome://settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 678343002: Default zoom was never read from chrome://settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Using round() api to round maximum/minimum zoom Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index 623cb14b38daf82935e19ba89717cf0ca615aa36..0588c320872b40addf365d7d18a3552a91f62813 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -3759,9 +3759,11 @@ blink::WebSpeechRecognizer* RenderViewImpl::speechRecognizer() {

void RenderViewImpl::zoomLimitsChanged(double minimum_level,

double maximum_level) {

- int minimum_percent = static_cast<int>(

+ // Round the double to avoid returning incorrect minimum/maximum zoom

+ // percentages.

+ int minimum_percent = round(

ZoomLevelToZoomFactor(minimum_level) * 100);

- int maximum_percent = static_cast<int>(

+ int maximum_percent = round(

ZoomLevelToZoomFactor(maximum_level) * 100);

Send(new ViewHostMsg_UpdateZoomLimits(