chrome/browser/ui/browser_command_controller.cc - Issue 678343002: Default zoom was never read from chrome://settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 678343002: Default zoom was never read from chrome://settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added unit test for reading default zoom from Settings Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_command_controller.cc

diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc

index f5f622c68cb54079d1af92106c3e477147f34d04..153fc56c7038ebd266b923f77ccabc6d20e10aa5 100644

--- a/chrome/browser/ui/browser_command_controller.cc

+++ b/chrome/browser/ui/browser_command_controller.cc

@@ -1138,9 +1138,12 @@ void BrowserCommandController::UpdateCommandsForZoomState() {

browser_->tab_strip_model()->GetActiveWebContents();

if (!contents)

return;

- command_updater_.UpdateCommandEnabled(IDC_ZOOM_PLUS, CanZoomIn(contents));

- command_updater_.UpdateCommandEnabled(IDC_ZOOM_NORMAL, ActualSize(contents));

- command_updater_.UpdateCommandEnabled(IDC_ZOOM_MINUS, CanZoomOut(contents));

+ command_updater_.UpdateCommandEnabled(IDC_ZOOM_PLUS,

+ IsAtMaximumZoom(contents));

+ command_updater_.UpdateCommandEnabled(IDC_ZOOM_NORMAL,

+ !IsAtDefaultZoom(contents));

+ command_updater_.UpdateCommandEnabled(IDC_ZOOM_MINUS,

+ IsAtMinimumZoom(contents));

}

void BrowserCommandController::UpdateCommandsForContentRestrictionState() {