Default zoom was never read from chrome://settings

chrome/browser/ui/browser_commands.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_commands.h"
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 547 matching lines @@
     // See http://crbug.com/6380.
     b->tab_strip_model()->GetActiveWebContents()->RestoreFocus();
   }
 }
 
 void CloseTab(Browser* browser) {
   content::RecordAction(UserMetricsAction("CloseTab_Accelerator"));
   browser->tab_strip_model()->CloseSelectedTabs();
 }
 
-bool CanZoomIn(content::WebContents* contents) {
+bool IsAtMaximumZoom(content::WebContents* contents) {
   ui_zoom::ZoomController* zoom_controller =
       ui_zoom::ZoomController::FromWebContents(contents);
-  return zoom_controller->GetZoomPercent() !=
-      contents->GetMaximumZoomPercent() + 1;
+  return zoom_controller->GetZoomPercent() != contents->GetMaximumZoomPercent();
 }

[Avi (use Gerrit), 2015/02/23 04:51:55]

This rename appears wrong. "CanZoomIn" makes sense; if the zoom percent isn't
the maximum zoom percent, we can zoom further. "IsAtMaximumZoom" is completely
wrong. It's _backwards_, returning true only when the value for the zoom percent
is *not* at the maximum zoom.

 
-bool CanZoomOut(content::WebContents* contents) {
+bool IsAtMinimumZoom(content::WebContents* contents) {
   ui_zoom::ZoomController* zoom_controller =
       ui_zoom::ZoomController::FromWebContents(contents);
   return zoom_controller->GetZoomPercent() !=
       contents->GetMinimumZoomPercent();
 }

[Avi (use Gerrit), 2015/02/23 04:51:55]

This rename appears wrong. "CanZoomOut" makes sense; if the zoom percent isn't
the minimum zoom percent, we can zoom further. "IsAtMinimumZoom" is completely
wrong. It's _backwards_, returning true only when the value for the zoom percent
is *not* at the minimum zoom.

 
-bool ActualSize(content::WebContents* contents) {
+bool IsAtDefaultZoom(content::WebContents* contents) {
   ui_zoom::ZoomController* zoom_controller =
       ui_zoom::ZoomController::FromWebContents(contents);
-  return zoom_controller->GetZoomPercent() != 100.0f;
+  return zoom_controller->IsAtDefaultZoom();
 }
 
 TabStripModelDelegate::RestoreTabType GetRestoreTabType(
     const Browser* browser) {
   TabRestoreService* service =
       TabRestoreServiceFactory::GetForProfile(browser->profile());
   if (!service || service->entries().empty())
     return TabStripModelDelegate::RESTORE_NONE;
   if (service->entries().front()->type == TabRestoreService::WINDOW)
     return TabStripModelDelegate::RESTORE_WINDOW;
@@ skipping 681 matching lines @@
                                           browser->host_desktop_type()));
   app_browser->tab_strip_model()->AppendWebContents(contents, true);
 
   contents->GetMutableRendererPrefs()->can_accept_load_drops = false;
   contents->GetRenderViewHost()->SyncRendererPrefs();
   app_browser->window()->Show();
 }
 #endif  // defined(ENABLE_EXTENSIONS)
 
 }  // namespace chrome