Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 678313002: Add ARMv8 detection in CpuFeatures. (Closed)

Created:
6 years, 1 month ago by sigurds
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -22 lines) Patch
M src/arm/assembler-arm.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/globals.h View 1 chunk +23 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sigurds
PTAL. This is the first approach to detecting ARMv8. I don't have hardware here to ...
6 years, 1 month ago (2014-10-28 11:24:52 UTC) #2
ulan
On 2014/10/28 11:24:52, sigurds wrote: > PTAL. This is the first approach to detecting ARMv8. ...
6 years, 1 month ago (2014-10-28 11:33:37 UTC) #3
ulan
On 2014/10/28 11:33:37, ulan wrote: > On 2014/10/28 11:24:52, sigurds wrote: > > PTAL. This ...
6 years, 1 month ago (2014-10-28 12:24:14 UTC) #4
Rodolph Perfetta (ARM)
lgtm
6 years, 1 month ago (2014-10-28 15:08:05 UTC) #5
sigurds
6 years, 1 month ago (2014-10-28 15:22:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24949 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698