Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 678263002: Update tokenizer to match spec (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Update tokenizer to match spec This CL is a rough pass over the HTMLTokenizer to align it with parsing.md. We'll need to do another pass more carefully in the future, but this CL gets us roughly in the right ballpark. We're not handling EOF properly. The parsing.md spec doesn't push the EOF though the parser, which breaks our current way of handling EOF. We do ok if we get EOF in the DataState, and that's enough to pass the tests for now. Also, update camel-case.sky to reflect the fact that the parser doesn't lower-case tag names anymore. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/adb2f5edbf8dcea52e9a50c270b1a1867e7bb7cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -248 lines) Patch
M sky/engine/core/html/parser/BackgroundHTMLParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/parser/HTMLToken.h View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/core/html/parser/HTMLTokenizer.h View 6 chunks +6 lines, -18 lines 0 comments Download
M sky/engine/core/html/parser/HTMLTokenizer.cpp View 15 chunks +83 lines, -225 lines 0 comments Download
M sky/engine/core/html/parser/MarkupTokenizerInlines.h View 1 chunk +12 lines, -1 line 0 comments Download
M sky/tests/lowlevel/camel-case.sky View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
abarth-chromium
6 years, 1 month ago (2014-10-28 03:39:23 UTC) #1
eseidel
lgtm
6 years, 1 month ago (2014-10-28 03:42:07 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 1 month ago (2014-10-28 03:45:57 UTC) #5
abarth-chromium
6 years, 1 month ago (2014-10-28 03:46:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
adb2f5edbf8dcea52e9a50c270b1a1867e7bb7cb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698