Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 678223002: Fix a bug in data_sender.js. (Closed)

Created:
6 years, 1 month ago by Sam McNally
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix a bug in data_sender.js. This fixes a bug where data sends that had been fully written to the data pipe were not considered when deciding whether to cancel (or wait for an in-progress cancel) during DataSender serialization. Committed: https://crrev.com/1fdff9eb3c08f8d654f0b485061240cf13bd2ef7 Cr-Commit-Position: refs/heads/master@{#301537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M extensions/renderer/resources/data_sender.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Sam McNally
6 years, 1 month ago (2014-10-27 23:25:00 UTC) #2
raymes
On 2014/10/27 23:25:00, Sam McNally wrote: lgtm
6 years, 1 month ago (2014-10-27 23:30:15 UTC) #3
Sam McNally
+rockot
6 years, 1 month ago (2014-10-27 23:41:29 UTC) #5
Ken Rockot(use gerrit already)
lgtm
6 years, 1 month ago (2014-10-27 23:48:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678223002/1
6 years, 1 month ago (2014-10-27 23:52:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-28 01:15:42 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 01:16:44 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1fdff9eb3c08f8d654f0b485061240cf13bd2ef7
Cr-Commit-Position: refs/heads/master@{#301537}

Powered by Google App Engine
This is Rietveld 408576698