Issue 678193005: Remove more frame-level scrolling machinery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 678193005: Remove more frame-level scrolling machinery. (Closed)

Created:
6 years, 1 month ago by ojan

Modified:
6 years, 1 month ago

Reviewers:
esprehn

CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -182 lines)			Patch
M	sky/engine/core/frame/FrameView.h	View	3 chunks	+0 lines, -9 lines	0 comments	Download
M	sky/engine/core/frame/FrameView.cpp	View	7 chunks	+3 lines, -51 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBlockFlow.cpp	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBox.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/rendering/compositing/RenderLayerCompositor.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/rendering/compositing/RenderLayerCompositor.cpp	View	1 chunk	+0 lines, -28 lines	0 comments	Download
M	sky/engine/public/web/WebDocument.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	sky/engine/public/web/WebFrame.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	sky/engine/public/web/WebWidget.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	sky/engine/web/WebDocument.cpp	View	1 chunk	+0 lines, -21 lines	0 comments	Download
M	sky/engine/web/WebLocalFrameImpl.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sky/engine/web/WebLocalFrameImpl.cpp	View	1 chunk	+0 lines, -24 lines	0 comments	Download
M	sky/engine/web/WebViewImpl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/web/WebViewImpl.cpp	View	3 chunks	+2 lines, -18 lines	0 comments	Download

Total messages: 3 (1 generated)

ojan

6 years, 1 month ago (2014-10-29 02:27:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
52517c108f6246dad7e7e8ee9fa45bd71179b8bb (presubmit successful).