Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 678193003: Fix two minor bugs found by /analyze (Closed)

Created:
5 years ago by brucedawson
Modified:
5 years ago
CC:
chromium-reviews, caitkp+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix two minor bugs found by /analyze BUG=427616 /analyze pointed out that the loop range-check used the comma operator when && was probably intended. The bug was harmless, but confusing, so I fixed it. /analyze also pointed out that the code was checking data read by a function and then checking whether the read succeeded. Reversing the order of the checks has no effect except to get rid of the undefined behavior. Committed: https://crrev.com/1fd77f5dac94f7bd887cfee74742e6894f14beac Cr-Commit-Position: refs/heads/master@{#301691}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome_elf/blacklist/blacklist.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brucedawson
5 years ago (2014-10-28 00:27:27 UTC) #2
robertshield
lgtm Ah, good finds, especially the comma operator.
5 years ago (2014-10-28 00:38:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678193003/1
5 years ago (2014-10-28 00:41:03 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
5 years ago (2014-10-28 06:45:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678193003/1
5 years ago (2014-10-28 19:47:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2014-10-28 19:58:32 UTC) #10
commit-bot: I haz the power
5 years ago (2014-10-28 19:59:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1fd77f5dac94f7bd887cfee74742e6894f14beac
Cr-Commit-Position: refs/heads/master@{#301691}

Powered by Google App Engine
This is Rietveld 408576698