cc: Full solid layers not at origin painted incorrectly

cc: Full solid layers not at origin painted incorrectly

Old code used a size, we now use a rect, and I didn't update the
quad clipping to use the origin offset.

We now correctly clip the quads, and I've updated the unit test
to use a visible rect that doesn't sit on (0,0), and will fail
without this change.

Though I wasn't able to reproduce it, it may also fix:
https://code.google.com/p/chromium/issues/detail?id=427467

BUG=18132446
(internal)

Committed: https://crrev.com/efe523e2b7b92af88a16a798b4059cc320901c85
Cr-Commit-Position: refs/heads/master@{#301519}

[hendrikw, 2014-10-27 22:48:41]

hendrikw@chromium.org changed reviewers:
+ danakj@chromium.org

[hendrikw, 2014-10-27 22:50:06]

I broke this with my last change, PTAL

[danakj, 2014-10-27 22:53:07]

LGTM

https://codereview.chromium.org/678193002/diff/1/cc/layers/solid_color_layer_...
File cc/layers/solid_color_layer_impl.cc (right):

https://codereview.chromium.org/678193002/diff/1/cc/layers/solid_color_layer_...
cc/layers/solid_color_layer_impl.cc:48: std::min(visible_content_rect.right() -
x, kSolidQuadTileSize),
throw these in temp vars like width/height so we don't compute them n^2 times?

[hendrikw, 2014-10-27 22:53:54]

The CQ bit was checked by hendrikw@chromium.org

[hendrikw, 2014-10-27 22:54:05]

The CQ bit was unchecked by hendrikw@chromium.org

[hendrikw, 2014-10-27 23:00:53]

Fixed the temporaries!  Thanks

[hendrikw, 2014-10-27 23:01:02]

The CQ bit was checked by hendrikw@chromium.org

[commit-bot: I haz the power, 2014-10-27 23:05:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/678193002/20001

[commit-bot: I haz the power, 2014-10-28 00:40:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-28 00:40:43]

Patchset 2 (id:??) landed as
https://crrev.com/efe523e2b7b92af88a16a798b4059cc320901c85
Cr-Commit-Position: refs/heads/master@{#301519}