Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1307)

Unified Diff: Source/core/rendering/style/StyleFilterData.h

Issue 678163002: Oilpan: move SVG property hierarchy to the heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/style/StyleFilterData.h
diff --git a/Source/core/rendering/style/StyleFilterData.h b/Source/core/rendering/style/StyleFilterData.h
index 9126ce7ac1db7b7fd53c51fb1332afefe667228c..d3a8f2bbfc8ce4b00ac348776118d9c40ca46577 100644
--- a/Source/core/rendering/style/StyleFilterData.h
+++ b/Source/core/rendering/style/StyleFilterData.h
@@ -27,15 +27,23 @@
#define StyleFilterData_h
#include "platform/graphics/filters/FilterOperations.h"
+#include "platform/heap/Handle.h"
#include "wtf/PassRefPtr.h"
#include "wtf/RefCounted.h"
namespace blink {
-class StyleFilterData : public RefCounted<StyleFilterData> {
+class StyleFilterData final : public RefCountedWillBeRefCountedGarbageCollected<StyleFilterData> {
haraken 2014/11/11 05:22:46 Why does this need to be RefCountedGarbageCollecte
sof 2014/11/12 13:45:07 StyleRareNonInheritedData has a DataRef<StyleFilte
public:
- static PassRefPtr<StyleFilterData> create() { return adoptRef(new StyleFilterData); }
- PassRefPtr<StyleFilterData> copy() const { return adoptRef(new StyleFilterData(*this)); }
+ static PassRefPtrWillBeRawPtr<StyleFilterData> create()
+ {
+ return adoptRefWillBeNoop(new StyleFilterData);
+ }
+
+ PassRefPtrWillBeRawPtr<StyleFilterData> copy() const
+ {
+ return adoptRefWillBeNoop(new StyleFilterData(*this));
+ }
bool operator==(const StyleFilterData&) const;
bool operator!=(const StyleFilterData& o) const
@@ -43,11 +51,16 @@ public:
return !(*this == o);
}
+ void trace(Visitor* visitor)
+ {
+ visitor->trace(m_operations);
+ }
+
FilterOperations m_operations;
private:
StyleFilterData();
- StyleFilterData(const StyleFilterData&);
+ explicit StyleFilterData(const StyleFilterData&);
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698