Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1378)

Unified Diff: Source/core/svg/SVGNumberList.cpp

Issue 678163002: Oilpan: move SVG property hierarchy to the heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased upto r185213 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGNumberList.h ('k') | Source/core/svg/SVGNumberList.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGNumberList.cpp
diff --git a/Source/core/svg/SVGNumberList.cpp b/Source/core/svg/SVGNumberList.cpp
index e5fa0db9564916d6c9f89bb91fad6f1f28a75947..061251c087afba6601a86713b7ce8da8dc4c5adf 100644
--- a/Source/core/svg/SVGNumberList.cpp
+++ b/Source/core/svg/SVGNumberList.cpp
@@ -28,9 +28,9 @@
namespace blink {
-inline PassRefPtr<SVGNumberList> toSVGNumberList(PassRefPtr<SVGPropertyBase> passBase)
+inline PassRefPtrWillBeRawPtr<SVGNumberList> toSVGNumberList(PassRefPtrWillBeRawPtr<SVGPropertyBase> passBase)
{
- RefPtr<SVGPropertyBase> base = passBase;
+ RefPtrWillBeRawPtr<SVGPropertyBase> base = passBase;
ASSERT(base->type() == SVGNumberList::classType());
return static_pointer_cast<SVGNumberList>(base.release());
}
@@ -104,7 +104,7 @@ void SVGNumberList::setValueAsString(const String& value, ExceptionState& except
void SVGNumberList::add(PassRefPtrWillBeRawPtr<SVGPropertyBase> other, SVGElement* contextElement)
{
- RefPtr<SVGNumberList> otherList = toSVGNumberList(other);
+ RefPtrWillBeRawPtr<SVGNumberList> otherList = toSVGNumberList(other);
if (length() != otherList->length())
return;
@@ -113,11 +113,11 @@ void SVGNumberList::add(PassRefPtrWillBeRawPtr<SVGPropertyBase> other, SVGElemen
at(i)->setValue(at(i)->value() + otherList->at(i)->value());
}
-void SVGNumberList::calculateAnimatedValue(SVGAnimationElement* animationElement, float percentage, unsigned repeatCount, PassRefPtr<SVGPropertyBase> fromValue, PassRefPtr<SVGPropertyBase> toValue, PassRefPtr<SVGPropertyBase> toAtEndOfDurationValue, SVGElement* contextElement)
+void SVGNumberList::calculateAnimatedValue(SVGAnimationElement* animationElement, float percentage, unsigned repeatCount, PassRefPtrWillBeRawPtr<SVGPropertyBase> fromValue, PassRefPtrWillBeRawPtr<SVGPropertyBase> toValue, PassRefPtrWillBeRawPtr<SVGPropertyBase> toAtEndOfDurationValue, SVGElement* contextElement)
{
- RefPtr<SVGNumberList> fromList = toSVGNumberList(fromValue);
- RefPtr<SVGNumberList> toList = toSVGNumberList(toValue);
- RefPtr<SVGNumberList> toAtEndOfDurationList = toSVGNumberList(toAtEndOfDurationValue);
+ RefPtrWillBeRawPtr<SVGNumberList> fromList = toSVGNumberList(fromValue);
+ RefPtrWillBeRawPtr<SVGNumberList> toList = toSVGNumberList(toValue);
+ RefPtrWillBeRawPtr<SVGNumberList> toAtEndOfDurationList = toSVGNumberList(toAtEndOfDurationValue);
size_t fromListSize = fromList->length();
size_t toListSize = toList->length();
@@ -137,7 +137,7 @@ void SVGNumberList::calculateAnimatedValue(SVGAnimationElement* animationElement
}
}
-float SVGNumberList::calculateDistance(PassRefPtr<SVGPropertyBase> to, SVGElement*)
+float SVGNumberList::calculateDistance(PassRefPtrWillBeRawPtr<SVGPropertyBase> to, SVGElement*)
{
// FIXME: Distance calculation is not possible for SVGNumberList right now. We need the distance for every single value.
return -1;
« no previous file with comments | « Source/core/svg/SVGNumberList.h ('k') | Source/core/svg/SVGNumberList.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698