Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Unified Diff: Source/core/svg/SVGNumber.h

Issue 678163002: Oilpan: move SVG property hierarchy to the heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased upto r185213 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGMatrixTearOff.cpp ('k') | Source/core/svg/SVGNumber.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGNumber.h
diff --git a/Source/core/svg/SVGNumber.h b/Source/core/svg/SVGNumber.h
index 5f096839303b9f55aa697af9f8b47a66319902be..ebae96ba52865e2704f8dd24d97da910a28821d4 100644
--- a/Source/core/svg/SVGNumber.h
+++ b/Source/core/svg/SVGNumber.h
@@ -44,12 +44,12 @@ public:
typedef SVGNumberTearOff TearOffType;
typedef float PrimitiveType;
- static PassRefPtr<SVGNumber> create(float value = 0.0f)
+ static PassRefPtrWillBeRawPtr<SVGNumber> create(float value = 0.0f)
{
- return adoptRef(new SVGNumber(value));
+ return adoptRefWillBeNoop(new SVGNumber(value));
}
- virtual PassRefPtr<SVGNumber> clone() const;
+ virtual PassRefPtrWillBeRawPtr<SVGNumber> clone() const;
float value() const { return m_value; }
void setValue(float value) { m_value = value; }
@@ -58,8 +58,8 @@ public:
virtual void setValueAsString(const String&, ExceptionState&);
virtual void add(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*) override;
- virtual void calculateAnimatedValue(SVGAnimationElement*, float percentage, unsigned repeatCount, PassRefPtr<SVGPropertyBase> from, PassRefPtr<SVGPropertyBase> to, PassRefPtr<SVGPropertyBase> toAtEndOfDurationValue, SVGElement* contextElement) override;
- virtual float calculateDistance(PassRefPtr<SVGPropertyBase> to, SVGElement* contextElement) override;
+ virtual void calculateAnimatedValue(SVGAnimationElement*, float percentage, unsigned repeatCount, PassRefPtrWillBeRawPtr<SVGPropertyBase> from, PassRefPtrWillBeRawPtr<SVGPropertyBase> to, PassRefPtrWillBeRawPtr<SVGPropertyBase> toAtEndOfDurationValue, SVGElement* contextElement) override;
+ virtual float calculateDistance(PassRefPtrWillBeRawPtr<SVGPropertyBase> to, SVGElement* contextElement) override;
static AnimatedPropertyType classType() { return AnimatedNumber; }
@@ -72,9 +72,9 @@ protected:
float m_value;
};
-inline PassRefPtr<SVGNumber> toSVGNumber(PassRefPtr<SVGPropertyBase> passBase)
+inline PassRefPtrWillBeRawPtr<SVGNumber> toSVGNumber(PassRefPtrWillBeRawPtr<SVGPropertyBase> passBase)
{
- RefPtr<SVGPropertyBase> base = passBase;
+ RefPtrWillBeRawPtr<SVGPropertyBase> base = passBase;
ASSERT(base->type() == SVGNumber::classType());
return static_pointer_cast<SVGNumber>(base.release());
}
@@ -85,16 +85,16 @@ inline PassRefPtr<SVGNumber> toSVGNumber(PassRefPtr<SVGPropertyBase> passBase)
// offset = "<number> | <percentage>"
class SVGNumberAcceptPercentage final : public SVGNumber {
public:
- static PassRefPtr<SVGNumberAcceptPercentage> create(float value = 0)
+ static PassRefPtrWillBeRawPtr<SVGNumberAcceptPercentage> create(float value = 0)
{
- return adoptRef(new SVGNumberAcceptPercentage(value));
+ return adoptRefWillBeNoop(new SVGNumberAcceptPercentage(value));
}
- virtual PassRefPtr<SVGNumber> clone() const override;
+ virtual PassRefPtrWillBeRawPtr<SVGNumber> clone() const override;
virtual void setValueAsString(const String&, ExceptionState&) override;
private:
- SVGNumberAcceptPercentage(float value);
+ explicit SVGNumberAcceptPercentage(float);
};
} // namespace blink
« no previous file with comments | « Source/core/svg/SVGMatrixTearOff.cpp ('k') | Source/core/svg/SVGNumber.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698