Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1629)

Unified Diff: Source/core/svg/SVGAnimatedNumber.h

Issue 678163002: Oilpan: move SVG property hierarchy to the heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased upto r185213 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGAnimatedLengthList.idl ('k') | Source/core/svg/SVGAnimatedNumber.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGAnimatedNumber.h
diff --git a/Source/core/svg/SVGAnimatedNumber.h b/Source/core/svg/SVGAnimatedNumber.h
index 43cf82234faee9519f81bdbe58d06c86821fc187..088007273d7678b88e3a46f95d6eea21cc6bd4f5 100644
--- a/Source/core/svg/SVGAnimatedNumber.h
+++ b/Source/core/svg/SVGAnimatedNumber.h
@@ -33,6 +33,7 @@
#include "core/svg/SVGNumberTearOff.h"
#include "core/svg/properties/SVGAnimatedProperty.h"
+#include "platform/heap/Handle.h"
namespace blink {
@@ -41,9 +42,9 @@ class SVGAnimatedNumberOptionalNumber;
// SVG Spec: http://www.w3.org/TR/SVG11/types.html#InterfaceSVGAnimatedNumber
class SVGAnimatedNumber : public SVGAnimatedProperty<SVGNumber> {
public:
- static PassRefPtr<SVGAnimatedNumber> create(SVGElement* contextElement, const QualifiedName& attributeName, PassRefPtr<SVGNumber> initialValue)
+ static PassRefPtrWillBeRawPtr<SVGAnimatedNumber> create(SVGElement* contextElement, const QualifiedName& attributeName, PassRefPtrWillBeRawPtr<SVGNumber> initialValue)
{
- return adoptRef(new SVGAnimatedNumber(contextElement, attributeName, initialValue));
+ return adoptRefWillBeNoop(new SVGAnimatedNumber(contextElement, attributeName, initialValue));
}
virtual void synchronizeAttribute() override;
@@ -53,15 +54,16 @@ public:
m_parentNumberOptionalNumber = numberOptionalNumber;
}
+ virtual void trace(Visitor*) override;
+
protected:
- SVGAnimatedNumber(SVGElement* contextElement, const QualifiedName& attributeName, PassRefPtr<SVGNumber> initialValue)
+ SVGAnimatedNumber(SVGElement* contextElement, const QualifiedName& attributeName, PassRefPtrWillBeRawPtr<SVGNumber> initialValue)
: SVGAnimatedProperty<SVGNumber>(contextElement, attributeName, initialValue)
- , m_parentNumberOptionalNumber(0)
+ , m_parentNumberOptionalNumber(nullptr)
{
}
- // FIXME: oilpan: This is kept as raw ptr as this is a back ptr. Change this to Member<> in oilpan.
- SVGAnimatedNumberOptionalNumber* m_parentNumberOptionalNumber;
+ RawPtrWillBeMember<SVGAnimatedNumberOptionalNumber> m_parentNumberOptionalNumber;
};
} // namespace blink
« no previous file with comments | « Source/core/svg/SVGAnimatedLengthList.idl ('k') | Source/core/svg/SVGAnimatedNumber.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698