Oilpan: move SVG property hierarchy to the heap.

Source/core/svg/SVGPathSeg.h

 /*
  * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 #ifndef SVGPathSeg_h
 #define SVGPathSeg_h
 
 #include "bindings/core/v8/ScriptWrappable.h"
+#include "platform/heap/Handle.h"
 #include "wtf/RefCounted.h"
 #include "wtf/text/WTFString.h"
 
 namespace blink {
 
 enum ListModification {
     ListModificationUnknown = 0,
     ListModificationInsert = 1,
     ListModificationReplace = 2,
     ListModificationRemove = 3,
@@ skipping 20 matching lines @@
     PathSegCurveToCubicSmoothAbs = 16,
     PathSegCurveToCubicSmoothRel = 17,
     PathSegCurveToQuadraticSmoothAbs = 18,
     PathSegCurveToQuadraticSmoothRel = 19
 };
 
 class SVGPropertyBase;
 class SVGPathElement;
 class SVGElement;
 
-class SVGPathSeg : public RefCounted<SVGPathSeg>, public ScriptWrappable {
+class SVGPathSeg : public RefCountedWillBeGarbageCollectedFinalized<SVGPathSeg>, public ScriptWrappable {
     DEFINE_WRAPPERTYPEINFO();
 public:
     // SVGPathSeg itself is used as a tear-off type.
     // FIXME: A tear-off type should be introduced to distinguish animVal/baseVal
     typedef SVGPathSeg TearOffType;
 
     explicit SVGPathSeg(SVGPathElement* contextElement);
 
     virtual ~SVGPathSeg() { }
 
@@ skipping 27 matching lines @@
     SVGPropertyBase* ownerList() const
     {
         return m_ownerList;
     }
 
     void setOwnerList(SVGPropertyBase* ownerList)
     {
         // Previous owner list must be cleared before setting new owner list.
         ASSERT((!ownerList && m_ownerList) || (ownerList && !m_ownerList));
 
         m_ownerList = ownerList;

[haraken, 2014/11/11 05:22:46]

It looks like this is called in some destructors, but are they OK? (I haven't
looked at the code.)

[sof, 2014/11/12 13:45:08]

It is not called from destructors (double checking now). It is called by
SVGListPropertyHelper<..>::clear(), but clear() is only invoked from a dtor if
!OILPAN.

     }
 
     void setContextElement(SVGElement* contextElement)
     {
         m_contextElement = contextElement;

[haraken, 2014/11/11 05:22:46]

Ditto.

[sof, 2014/11/12 13:45:08]

Same, never called to clear out m_contextElement.

     }
 
-    static PassRefPtr<SVGPathSeg> create() { ASSERT_NOT_REACHED(); return nullptr; }
-    PassRefPtr<SVGPathSeg> clone() { ASSERT_NOT_REACHED(); return nullptr; }
+    static PassRefPtrWillBeRawPtr<SVGPathSeg> create() { ASSERT_NOT_REACHED(); return nullptr; }
+    PassRefPtrWillBeRawPtr<SVGPathSeg> clone() { ASSERT_NOT_REACHED(); return nullptr; }
+
+    virtual void trace(Visitor*);
 
 protected:
     void commitChange();
 
 private:
-    // FIXME: oilpan: These are kept as raw ptrs to break reference cycle. Should be Member in oilpan.
-    SVGPropertyBase* m_ownerList;
-    SVGElement* m_contextElement;
+    RawPtrWillBeMember<SVGPropertyBase> m_ownerList;
+    RawPtrWillBeMember<SVGElement> m_contextElement;
 };
 
 } // namespace blink
 
 #endif // SVGPathSeg_h