Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issue 678153002: Add SK_API to global scope operators of SkMatrix (Closed)

Created:
6 years, 1 month ago by Justin Novosad
Modified:
6 years, 1 month ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add SK_API to global scope operators of SkMatrix Committed: https://skia.googlesource.com/skia/+/ed53742e92c94d5ce20b982833725cf20546aaca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M include/core/SkMatrix.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Justin Novosad
PTAL
6 years, 1 month ago (2014-10-27 22:26:21 UTC) #2
reed1
this, or we can change them to member methods. lgtm
6 years, 1 month ago (2014-10-28 13:53:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678153002/1
6 years, 1 month ago (2014-10-28 14:06:19 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 14:15:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as ed53742e92c94d5ce20b982833725cf20546aaca

Powered by Google App Engine
This is Rietveld 408576698