Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 678103003: Increase WebRTC socket send buffer to 256k. (Closed)

Created:
6 years, 1 month ago by guoweis_left_chromium
Modified:
6 years, 1 month ago
Reviewers:
juberti2, davidben, guoweis2
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Increase WebRTC socket send buffer to 256k. WebRTC has a throttling mechanism to ensure we don't push too much data into the system socket. The buffer size doesn't seem to be set correctly and it was experienced video freeze from time to time as the throttling mechanism kicks in too frequently and causes video packets dropped, even though system still has more capacity to handle it. BUG=427555 Committed: https://crrev.com/08114182ecdd79be715812199abb1da33a6bae74 Cr-Commit-Position: refs/heads/master@{#301580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/renderer/p2p/ipc_socket_factory.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
guoweis2
PTAL
6 years, 1 month ago (2014-10-27 23:55:57 UTC) #2
guoweis2
davidben@chromium.org: Please OWNER review changes in this CL.
6 years, 1 month ago (2014-10-27 23:57:32 UTC) #4
davidben
lgtm
6 years, 1 month ago (2014-10-28 00:12:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678103003/1
6 years, 1 month ago (2014-10-28 00:41:05 UTC) #7
juberti2
lgtm
6 years, 1 month ago (2014-10-28 00:42:03 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/builds/6881)
6 years, 1 month ago (2014-10-28 01:15:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678103003/1
6 years, 1 month ago (2014-10-28 01:18:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678103003/1
6 years, 1 month ago (2014-10-28 06:23:49 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-28 06:56:47 UTC) #16
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 06:57:22 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08114182ecdd79be715812199abb1da33a6bae74
Cr-Commit-Position: refs/heads/master@{#301580}

Powered by Google App Engine
This is Rietveld 408576698