chrome/browser/ui/views/location_bar/star_view.h - Issue 678093002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/star_view.h

Issue 678093002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/selected_keyword_view.h ('k') | chrome/browser/ui/views/location_bar/translate_icon_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/star_view.h

diff --git a/chrome/browser/ui/views/location_bar/star_view.h b/chrome/browser/ui/views/location_bar/star_view.h

index dcfe68549919b20dccebe1fcf12409faef9344aa..58f4f2e661a74a195f7086c2d9efaa51dce51cc5 100644

--- a/chrome/browser/ui/views/location_bar/star_view.h

+++ b/chrome/browser/ui/views/location_bar/star_view.h

@@ -13,16 +13,15 @@ class CommandUpdater;

class StarView : public BubbleIconView {

public:

explicit StarView(CommandUpdater* command_updater);

- virtual ~StarView();

+ ~StarView() override;

// Toggles the star on or off.

void SetToggled(bool on);

protected:

// BubbleIconView:

- virtual bool IsBubbleShowing() const override;

- virtual void OnExecuting(

- BubbleIconView::ExecuteSource execute_source) override;

+ bool IsBubbleShowing() const override;

+ void OnExecuting(BubbleIconView::ExecuteSource execute_source) override;

private:

DISALLOW_COPY_AND_ASSIGN(StarView);