chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.h - Issue 678093002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.h

Issue 678093002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/location_icon_view.h ('k') | chrome/browser/ui/views/location_bar/origin_chip_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.h

diff --git a/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.h b/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.h

index 5f08c30113965928b0db857b44dd56c4b5e21ad6..72eb26716c52f446b5a46a6a456f40ef897332f6 100644

--- a/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.h

+++ b/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.h

@@ -23,7 +23,7 @@ class OpenPDFInReaderView : public views::ImageView,

public views::WidgetObserver {

public:

OpenPDFInReaderView();

- virtual ~OpenPDFInReaderView();

+ ~OpenPDFInReaderView() override;

void Update(content::WebContents* web_contents);

@@ -31,13 +31,13 @@ class OpenPDFInReaderView : public views::ImageView,

void ShowBubble();

// views::ImageView:

- virtual void GetAccessibleState(ui::AXViewState* state) override;

- virtual bool OnMousePressed(const ui::MouseEvent& event) override;

- virtual void OnMouseReleased(const ui::MouseEvent& event) override;

- virtual bool OnKeyPressed(const ui::KeyEvent& event) override;

+ void GetAccessibleState(ui::AXViewState* state) override;

+ bool OnMousePressed(const ui::MouseEvent& event) override;

+ void OnMouseReleased(const ui::MouseEvent& event) override;

+ bool OnKeyPressed(const ui::KeyEvent& event) override;

// views::WidgetObserver:

- virtual void OnWidgetDestroying(views::Widget* widget) override;

+ void OnWidgetDestroying(views::Widget* widget) override;

OpenPDFInReaderBubbleView* bubble_;