content/browser/site_instance_impl_unittest.cc - Issue 678073006: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/site_instance_impl_unittest.cc

Issue 678073006: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bogus formatting Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/shared_worker/shared_worker_service_impl_unittest.cc ('k') | content/browser/speech/google_streaming_remote_engine_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/site_instance_impl_unittest.cc

diff --git a/content/browser/site_instance_impl_unittest.cc b/content/browser/site_instance_impl_unittest.cc

index 70fd28ad2a5717f012236f99e9e38b37bc180acd..993ef35179a20b2d68ef25d83f36caa741807f47 100644

--- a/content/browser/site_instance_impl_unittest.cc

+++ b/content/browser/site_instance_impl_unittest.cc

@@ -90,7 +90,7 @@ class SiteInstanceTest : public testing::Test {

old_browser_client_(NULL) {

}

- virtual void SetUp() {

+ void SetUp() override {

old_browser_client_ = SetBrowserClientForTesting(&browser_client_);

url::AddStandardScheme(kPrivilegedScheme);

url::AddStandardScheme(kChromeUIScheme);

@@ -98,7 +98,7 @@ class SiteInstanceTest : public testing::Test {

SiteInstanceImpl::set_render_process_host_factory(&rph_factory_);

}

- virtual void TearDown() {

+ void TearDown() override {

// Ensure that no RenderProcessHosts are left over after the tests.

EXPECT_TRUE(RenderProcessHost::AllHostsIterator().IsAtEnd());