Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

Issue 678073006: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix bogus formatting Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
diff --git a/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc b/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
index 7ec1f15b78fc2891365b62b68c3de823e2bc5716..7c6ad3282a733874aa7637b558f2b6278d4dcee6 100644
--- a/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
+++ b/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
@@ -77,7 +77,7 @@ class SSLCertificateErrorJob : public net::URLRequestTestJob {
response_data,
auto_advance),
weak_factory_(this) {}
- virtual void Start() override {
+ void Start() override {
base::MessageLoop::current()->PostTask(
FROM_HERE,
base::Bind(&SSLCertificateErrorJob::NotifyError,
@@ -116,7 +116,7 @@ class CertStatusErrorJob : public net::URLRequestTestJob {
response_headers,
response_data,
auto_advance) {}
- virtual void GetResponseInfo(net::HttpResponseInfo* info) override {
+ void GetResponseInfo(net::HttpResponseInfo* info) override {
URLRequestTestJob::GetResponseInfo(info);
info->ssl_info.cert_status = net::CERT_STATUS_DATE_INVALID;
}
@@ -145,7 +145,7 @@ class MockHttpProtocolHandler
: resource_context_(resource_context) {}
~MockHttpProtocolHandler() override {}
- virtual net::URLRequestJob* MaybeCreateJob(
+ net::URLRequestJob* MaybeCreateJob(
net::URLRequest* request,
net::NetworkDelegate* network_delegate) const override {
ServiceWorkerRequestHandler* handler =
@@ -173,7 +173,7 @@ class ServiceWorkerWriteToCacheJobTest : public testing::Test {
mock_protocol_handler_(NULL) {}
~ServiceWorkerWriteToCacheJobTest() override {}
- virtual void SetUp() override {
+ void SetUp() override {
helper_.reset(new EmbeddedWorkerTestHelper(kMockRenderProcessId));
// A new unstored registration/version.
@@ -218,7 +218,7 @@ class ServiceWorkerWriteToCacheJobTest : public testing::Test {
scoped_refptr<ResourceRequestBody>());
}
- virtual void TearDown() override {
+ void TearDown() override {
request_.reset();
url_request_context_.reset();
url_request_job_factory_.reset();

Powered by Google App Engine
This is Rietveld 408576698