content/browser/service_worker/service_worker_url_request_job_unittest.cc - Issue 678073006: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_url_request_job_unittest.cc

Issue 678073006: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bogus formatting Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_storage_unittest.cc ('k') | content/browser/service_worker/service_worker_version_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_url_request_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_url_request_job_unittest.cc b/content/browser/service_worker/service_worker_url_request_job_unittest.cc

index 3668351d5e623ecdf67c77b261f46db3c2dc92d1..76f718e27dc970dda2ac60ee9fcfe03a470f28f7 100644

--- a/content/browser/service_worker/service_worker_url_request_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_url_request_job_unittest.cc

@@ -96,9 +96,9 @@ class ServiceWorkerURLRequestJobTest : public testing::Test {

ServiceWorkerURLRequestJobTest()

: thread_bundle_(TestBrowserThreadBundle::IO_MAINLOOP),

blob_data_(new storage::BlobData("blob-id:myblob")) {}

- virtual ~ServiceWorkerURLRequestJobTest() {}

+ ~ServiceWorkerURLRequestJobTest() override {}

- virtual void SetUp() override {

+ void SetUp() override {

browser_context_.reset(new TestBrowserContext);

SetUpWithHelper(new EmbeddedWorkerTestHelper(kProcessID));

}

@@ -141,7 +141,7 @@ class ServiceWorkerURLRequestJobTest : public testing::Test {

helper_->context()->AddProviderHost(provider_host.Pass());

}

- virtual void TearDown() override {

+ void TearDown() override {

version_ = NULL;

registration_ = NULL;

helper_.reset();