content/browser/service_worker/service_worker_registration_unittest.cc - Issue 678073006: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration_unittest.cc

Issue 678073006: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bogus formatting Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_provider_host_unittest.cc ('k') | content/browser/service_worker/service_worker_request_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_registration_unittest.cc

diff --git a/content/browser/service_worker/service_worker_registration_unittest.cc b/content/browser/service_worker/service_worker_registration_unittest.cc

index 73d383ef533d03cc20e9bf8f9edbb626bdb114f4..2adb68d32b97c43f502af41d2de7703f7450c353 100644

--- a/content/browser/service_worker/service_worker_registration_unittest.cc

+++ b/content/browser/service_worker/service_worker_registration_unittest.cc

@@ -22,7 +22,7 @@ class ServiceWorkerRegistrationTest : public testing::Test {

ServiceWorkerRegistrationTest()

: io_thread_(BrowserThread::IO, &message_loop_) {}

- virtual void SetUp() override {

+ void SetUp() override {

scoped_ptr<ServiceWorkerDatabaseTaskManager> database_task_manager(

new MockServiceWorkerDatabaseTaskManager(

base::ThreadTaskRunnerHandle::Get()));

@@ -38,7 +38,7 @@ class ServiceWorkerRegistrationTest : public testing::Test {

context_ptr_ = context_->AsWeakPtr();

}

- virtual void TearDown() override {

+ void TearDown() override {

context_.reset();

base::RunLoop().RunUntilIdle();

}