content/browser/gpu/gpu_data_manager_impl_private_unittest.cc - Issue 678073006: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/gpu/gpu_data_manager_impl_private_unittest.cc

Issue 678073006: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bogus formatting Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/geolocation/wifi_data_provider_linux_unittest.cc ('k') | content/browser/gpu/shader_disk_cache_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/gpu/gpu_data_manager_impl_private_unittest.cc

diff --git a/content/browser/gpu/gpu_data_manager_impl_private_unittest.cc b/content/browser/gpu/gpu_data_manager_impl_private_unittest.cc

index 00963fe3eb9f04920a9eaca420f9c66a15ddad60..8bcb01052e723fd1d3b61c2813a552840af2ad10 100644

--- a/content/browser/gpu/gpu_data_manager_impl_private_unittest.cc

+++ b/content/browser/gpu/gpu_data_manager_impl_private_unittest.cc

@@ -71,7 +71,7 @@ class GpuDataManagerImplPrivateTest : public testing::Test {

public:

GpuDataManagerImplPrivateTest() { }

- virtual ~GpuDataManagerImplPrivateTest() { }

+ ~GpuDataManagerImplPrivateTest() override {}

protected:

// scoped_ptr doesn't work with GpuDataManagerImpl because its

@@ -117,11 +117,9 @@ class GpuDataManagerImplPrivateTest : public testing::Test {

DISALLOW_COPY_AND_ASSIGN(ScopedGpuDataManagerImplPrivate);

};

- virtual void SetUp() {

- }

+ void SetUp() override {}

- virtual void TearDown() {

- }

+ void TearDown() override {}

base::Time JustBeforeExpiration(const GpuDataManagerImplPrivate* manager);

base::Time JustAfterExpiration(const GpuDataManagerImplPrivate* manager);