content/browser/frame_host/render_frame_host_manager_unittest.cc - Issue 678073006: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager_unittest.cc

Issue 678073006: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bogus formatting Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigation_entry_impl_unittest.cc ('k') | content/browser/frame_host/render_widget_host_view_child_frame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager_unittest.cc

diff --git a/content/browser/frame_host/render_frame_host_manager_unittest.cc b/content/browser/frame_host/render_frame_host_manager_unittest.cc

index f74e412caece04cbc346d074e8027741d6f5fb46..7bcd167cc39a0da2668bd421b644c1f6a168a3ad 100644

--- a/content/browser/frame_host/render_frame_host_manager_unittest.cc

+++ b/content/browser/frame_host/render_frame_host_manager_unittest.cc

@@ -297,13 +297,13 @@ class FrameLifetimeConsistencyChecker : public WebContentsObserver {

class RenderFrameHostManagerTest

: public RenderViewHostImplTestHarness {

public:

- virtual void SetUp() override {

+ void SetUp() override {

RenderViewHostImplTestHarness::SetUp();

WebUIControllerFactory::RegisterFactory(&factory_);

lifetime_checker_.reset(new FrameLifetimeConsistencyChecker(contents()));

}

- virtual void TearDown() override {

+ void TearDown() override {

lifetime_checker_.reset();

RenderViewHostImplTestHarness::TearDown();

WebUIControllerFactory::UnregisterFactoryForTesting(&factory_);