content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc - Issue 678073006: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc

Issue 678073006: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/power_monitor_message_broadcaster_unittest.cc ('K') | « content/browser/service_worker/service_worker_context_unittest.cc ('k') | content/browser/service_worker/service_worker_dispatcher_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc

diff --git a/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc b/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc

index fe3aff68b73de09cd369075056c6938f6d2b423a..9a6835addb72d7e108833482cfd85eea2ed053b6 100644

--- a/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc

+++ b/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc

@@ -42,7 +42,7 @@ class ServiceWorkerControlleeRequestHandlerTest : public testing::Test {

ServiceWorkerControlleeRequestHandlerTest()

: browser_thread_bundle_(TestBrowserThreadBundle::IO_MAINLOOP) {}

- virtual void SetUp() override {

+ void SetUp() override {

helper_.reset(new EmbeddedWorkerTestHelper(kMockRenderProcessId));

// A new unstored registration/version.

@@ -64,7 +64,7 @@ class ServiceWorkerControlleeRequestHandlerTest : public testing::Test {

base::RunLoop().RunUntilIdle();

}

- virtual void TearDown() override {

+ void TearDown() override {

version_ = NULL;

registration_ = NULL;

helper_.reset();