content/browser/fileapi/file_system_file_stream_reader_unittest.cc - Issue 678073006: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/fileapi/file_system_file_stream_reader_unittest.cc

Issue 678073006: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/fileapi/file_system_dir_url_request_job_unittest.cc ('k') | content/browser/fileapi/file_system_operation_impl_unittest.cc » ('j') | content/browser/power_monitor_message_broadcaster_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/fileapi/file_system_file_stream_reader_unittest.cc

diff --git a/content/browser/fileapi/file_system_file_stream_reader_unittest.cc b/content/browser/fileapi/file_system_file_stream_reader_unittest.cc

index d927ce4a9ba3839339e939042aacd6d960c2b50d..5e13f15c28800526c156f3ce52ec7e4e6b4be35c 100644

--- a/content/browser/fileapi/file_system_file_stream_reader_unittest.cc

+++ b/content/browser/fileapi/file_system_file_stream_reader_unittest.cc

@@ -67,7 +67,7 @@ class FileSystemFileStreamReaderTest : public testing::Test {

public:

FileSystemFileStreamReaderTest() {}

- virtual void SetUp() override {

+ void SetUp() override {

ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());

file_system_context_ = CreateFileSystemContextForTesting(

@@ -84,9 +84,7 @@ class FileSystemFileStreamReaderTest : public testing::Test {

&test_file_modification_time_);

}

- virtual void TearDown() override {

- base::RunLoop().RunUntilIdle();

- }

+ void TearDown() override { base::RunLoop().RunUntilIdle(); }

protected:

storage::FileSystemFileStreamReader* CreateFileReader(