Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: content/browser/devtools/devtools_manager_unittest.cc

Issue 678073006: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix bogus formatting Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "base/memory/scoped_ptr.h" 6 #include "base/memory/scoped_ptr.h"
7 #include "base/time/time.h" 7 #include "base/time/time.h"
8 #include "content/browser/devtools/devtools_manager.h" 8 #include "content/browser/devtools/devtools_manager.h"
9 #include "content/browser/devtools/embedded_worker_devtools_manager.h" 9 #include "content/browser/devtools/embedded_worker_devtools_manager.h"
10 #include "content/browser/devtools/render_view_devtools_agent_host.h" 10 #include "content/browser/devtools/render_view_devtools_agent_host.h"
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 }; 195 };
196 196
197 } // namespace 197 } // namespace
198 198
199 class DevToolsManagerTest : public RenderViewHostImplTestHarness { 199 class DevToolsManagerTest : public RenderViewHostImplTestHarness {
200 public: 200 public:
201 DevToolsManagerTest() 201 DevToolsManagerTest()
202 : old_browser_client_(NULL) {} 202 : old_browser_client_(NULL) {}
203 203
204 protected: 204 protected:
205 virtual void SetUp() override { 205 void SetUp() override {
206 RenderViewHostImplTestHarness::SetUp(); 206 RenderViewHostImplTestHarness::SetUp();
207 TestDevToolsClientHost::ResetCounters(); 207 TestDevToolsClientHost::ResetCounters();
208 old_browser_client_ = SetBrowserClientForTesting(&browser_client_); 208 old_browser_client_ = SetBrowserClientForTesting(&browser_client_);
209 } 209 }
210 210
211 virtual void TearDown() override { 211 void TearDown() override {
212 SetBrowserClientForTesting(old_browser_client_); 212 SetBrowserClientForTesting(old_browser_client_);
213 RenderViewHostImplTestHarness::TearDown(); 213 RenderViewHostImplTestHarness::TearDown();
214 } 214 }
215 215
216 ContentBrowserClientWithDevTools browser_client_; 216 ContentBrowserClientWithDevTools browser_client_;
217 ContentBrowserClient* old_browser_client_; 217 ContentBrowserClient* old_browser_client_;
218 }; 218 };
219 219
220 TEST_F(DevToolsManagerTest, OpenAndManuallyCloseDevToolsClientHost) { 220 TEST_F(DevToolsManagerTest, OpenAndManuallyCloseDevToolsClientHost) {
221 scoped_refptr<DevToolsAgentHost> agent( 221 scoped_refptr<DevToolsAgentHost> agent(
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
451 EXPECT_TRUE(scheduler.IsEmpty()); 451 EXPECT_TRUE(scheduler.IsEmpty());
452 EXPECT_EQ(4, observer->updates_count()); 452 EXPECT_EQ(4, observer->updates_count());
453 453
454 manager->RemoveObserver(observer.get()); 454 manager->RemoveObserver(observer.get());
455 455
456 EXPECT_TRUE(scheduler.IsEmpty()); 456 EXPECT_TRUE(scheduler.IsEmpty());
457 manager->SetSchedulerForTest(DevToolsManager::Scheduler()); 457 manager->SetSchedulerForTest(DevToolsManager::Scheduler());
458 } 458 }
459 459
460 } // namespace content 460 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698